]> review.fuel-infra Code Review - openstack-build/heat-build.git/commit
Code Review / openstack-build / heat-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 4fd7441) | patch
Don't use a query for stack_get()
authorZane Bitter <zbitter@redhat.com>
Mon, 2 Sep 2013 14:00:36 +0000 (16:00 +0200)
committerZane Bitter <zbitter@redhat.com>
Mon, 2 Sep 2013 14:00:36 +0000 (16:00 +0200)
commitf1da4547beff30c922bdf8dca7e074f64bd6ae88
tree9199cf0caf87572868fa838fe713c1551a4d7a95tree | snapshot
parent4fd744173f7f8ab5a0e4e825e85f2729bed18677commit | diff
Don't use a query for stack_get()

When getting a database record by ID, it is much more efficient to get() it
directly than to perform a query or the database to obtain the ID (again)
and then get it.

Since stack_get() returns only a single record that can be trivially
checked for deletion in code, do this rather than performing a query with a
filter.

Change-Id: I4bb3ea1a9c4ae928fe0f5bce5c02b842a3f1ab4f
heat/db/sqlalchemy/api.py diff | blob | history