]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
VMware: Unit test refactoring
authorVipin Balachandran <vbala@vmware.com>
Mon, 19 Oct 2015 06:55:54 +0000 (12:25 +0530)
committerVipin Balachandran <vbala@vmware.com>
Tue, 20 Oct 2015 12:24:05 +0000 (17:54 +0530)
commitf13777da65f57e49aa109661a588c6ee3695144d
tree335b3026f56f163d771ff913e6bf1acaacf8e01f
parent3b0fcc3e758b6763d93aa2cea40aa46748201e99
VMware: Unit test refactoring

Some of the unit tests use mox instead of mock. Also, there are
cases where a single test tests multiple cases and methods. This
patch refactors the unit tests for the following methods in the
vmdk module to fix these issues:

* get_volume_stats
* _verify_volume_creation
* create_volume
* delete_volume
* _get_extra_spec_disk_type
* _get_disk_type
* create_snapshot
* delete_snapshot

There will be follow-up patches to fix the remaining unit tests.

Partial-bug: #1261097
Change-Id: I17b1c0df4e13bf9900a2fe8d37ff5297a8e7486e
cinder/tests/unit/test_vmware_vmdk.py