]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Fix broken solidfire create-snapshot
authorJohn Griffith <john.griffith@solidfire.com>
Thu, 3 Oct 2013 21:54:20 +0000 (15:54 -0600)
committerThierry Carrez <thierry@openstack.org>
Fri, 4 Oct 2013 07:46:33 +0000 (09:46 +0200)
commitf021629df31328324ca429c29a827efab832eee0
tree00874785c3b45e061c06b8c1eef8679437c7567c
parente01eba47b94c3cbb41491acdbcabd9ba14936be6
Fix broken solidfire create-snapshot

A previous change to enable secifying size for cloned volumes
created introduced a bug that breaks the ability to create-snapshots
when using the SolidFire driver
(CID: I5628c7fa922780d6b0601e2daa79310a61085edc).

The problem is that we use a shared method in the SF driver for both
create-clone and create-snapshot, the added change only considers the
clone case and does a get ref['size'] but in the case of snapshots
this needs to be ref['volume_size'].

Change-Id: I50603b3ac43f2c3c7e7811ec34de078a268519f7
Closes-Bug: 1234970
(cherry picked from commit 3cd27defb1c820ceadd8bbc6bfd5a405a7376cdb)
cinder/tests/test_solidfire.py
cinder/volume/drivers/solidfire.py