]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Introduce kill_signal parameter to AsynProcess.stop()
authorJakub Libosvar <libosvar@redhat.com>
Thu, 17 Sep 2015 13:26:05 +0000 (13:26 +0000)
committerAssaf Muller <amuller@redhat.com>
Thu, 17 Sep 2015 21:39:19 +0000 (17:39 -0400)
commitecbc2e3ed36964ed8944b3a128cde6850e250dd5
treef2edd9030e6e41a97d14433b084b2edef06f6f17
parent693db7cf7cac4c0fc4aeaffd113b9d833a950a52
Introduce kill_signal parameter to AsynProcess.stop()

All stop() calls of instances of AsyncProcess class were sending
hardcoded SIGKILL signal to its process. This patch leaves the default
behavior to SIGKILL but offers any number to be sent to kill command.

Note: Internal private methods also got a new parameter which is not
      appended. Given that those methods are private and thus not used
      outside of the class, we can afford it.

Change-Id: Ib7b0273c134d59c6a50173d4c2eb35761fcd3d62
Related-Bug: #1487548
neutron/agent/linux/async_process.py
neutron/tests/functional/agent/linux/test_ovsdb_monitor.py
neutron/tests/unit/agent/linux/test_async_process.py