]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Make keepalived add_vip idempotent
authorAssaf Muller <amuller@redhat.com>
Tue, 8 Dec 2015 22:44:07 +0000 (17:44 -0500)
committerAssaf Muller <amuller@redhat.com>
Tue, 8 Dec 2015 23:26:07 +0000 (18:26 -0500)
commiteb84048bbc27d6743016da9beeda071ccb92cd9c
tree3d81bed815c56aad87211fd27139d329131ccc70
parentc51f56f57b5cf67fc5e174b2d7a219990b666809
Make keepalived add_vip idempotent

L3 agent operations are designed to be idempotent to be resiliant
in the face of missed notifications, out of order notifications
processing and agent restarts. One exception is keepalived's
add_vip that was made to explicitly barf when the agent tries
to add a vip that was already inserted to keepalive'd internal
cache. This was done in patch 142630 by my request to root
out bugs. Well, we found such a bug and in retrospect may not
have been the smartest idea.

Change-Id: Iead975787e2847828286d7b644dcbe33cf57ace9
Related-Bug: #1523999
neutron/agent/l3/ha_router.py
neutron/agent/linux/keepalived.py
neutron/tests/unit/agent/linux/test_keepalived.py