]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove excessive fallback iptables ACCEPT rules
authorKevin Benton <blak111@gmail.com>
Mon, 5 Oct 2015 14:06:54 +0000 (07:06 -0700)
committerArmando Migliaccio <armamig@gmail.com>
Thu, 8 Oct 2015 17:59:10 +0000 (17:59 +0000)
commitea8de8a9dd808b1379060e0ce578b8129f45c3ae
tree7c2ecdb63e441e912a55b5510e8c17c892edddba
parent44cc4b9a632523d997cc3f03dfed91d3c92259c5
Remove excessive fallback iptables ACCEPT rules

The previous code was generating a fallback ACCEPT rule for every
port when there should only be one at the very end. The reason that
this wasn't causing a bug is because we have a duplicate rule remover
that was silently throwing away the extras and it happened to get them
in the right order.

Closes-Bug: #1502906
Change-Id: I83cf574f93b512be1ccefdc8da63e1783d279233
neutron/agent/linux/iptables_firewall.py
neutron/tests/unit/agent/linux/test_iptables_firewall.py
neutron/tests/unit/agent/test_securitygroups_rpc.py