]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Code Review / openstack-build / neutron-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: e2c7249) | patch
Raise NotImplementedError instead of NotImplemented
authorChristian Berendt <berendt@b1-systems.de>
Fri, 4 Jul 2014 11:12:26 +0000 (13:12 +0200)
committerChristian Berendt <berendt@b1-systems.de>
Wed, 13 Aug 2014 08:54:07 +0000 (10:54 +0200)
commite8e2392321e0fd3e2b8a0345b725f2e8df854a34
treea29deac0970f0e92a180a2e122bc0eaecbe8b585tree | snapshot
parente2c72495f4cacbafb650fb1e429ea68ba8c07836commit | diff
Raise NotImplementedError instead of NotImplemented

NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).

NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).

It makes no sense to raise a constant. The exception should
be raised instead.

Change-Id: I4969e26eb7b46f008ea3c8bd0093490c425f7069
Closes-Bug: #1339855
neutron/agent/linux/polling.py diff | blob | history
neutron/tests/unit/agent/linux/test_polling.py diff | blob | history