]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Execute ipset command using check_exit_code
authorshihanzhang <shihanzhang@huawei.com>
Fri, 18 Sep 2015 02:38:43 +0000 (10:38 +0800)
committershihanzhang <shihanzhang@huawei.com>
Mon, 21 Sep 2015 09:13:22 +0000 (09:13 +0000)
commite82733f5d9adefaf4ee2a9ff4ea615c5e0cb91a9
tree066a0b446e63901c5208c5c84dfd6aba4bc15aed
parent693db7cf7cac4c0fc4aeaffd113b9d833a950a52
Execute ipset command using check_exit_code

When l2 agent execute ipset command, we should pass
parameter 'check_exit_code' to self.execute acording to
action.
The intention is to safely fail if we try to destroy a
non existing set, or delete a non existing member.
Otherwise the agent gets stuck in a loop if such situation
happens. Such kind of event would be logged as errors.

Change-Id: If67330523d114d6da13d0280851e7138a51d08f7
Closes-bug: #1497074
neutron/agent/linux/ipset_manager.py
neutron/tests/functional/agent/linux/test_ipset.py
neutron/tests/unit/agent/linux/test_ipset_manager.py