]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commit
Code Review / puppet-modules / puppetlabs-firewall.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 8ce7b7a) | patch
(MODULES-442) Correct boolean properties behavior
authorHunter Haugen <hunter@puppetlabs.com>
Fri, 31 Jan 2014 21:19:27 +0000 (13:19 -0800)
committerHunter Haugen <hunter@puppetlabs.com>
Mon, 3 Feb 2014 20:57:10 +0000 (12:57 -0800)
commite6a10401d3cad847a15513a6c6990ec5eff87274
treec67f8d55f60b28d086f5d17a3fae6ace723c7044tree | snapshot
parent8ce7b7a274207067347088b36ffa493942eae207commit | diff
(MODULES-442) Correct boolean properties behavior

The boolean properties had a few things incorrect with them.

- Any value passed was considered `true`. This was compounded further by
  the next issue.
- When the read property was false, it was set to 'nil'. This caused
  `<property> => false` to not work after the previous was fixed.

Random other fixes to tests that were failing or poorly implemented are
also included
lib/puppet/provider/firewall/ip6tables.rb diff | blob | history
lib/puppet/provider/firewall/iptables.rb diff | blob | history
spec/acceptance/change_source_spec.rb diff | blob | history
spec/acceptance/firewall_spec.rb diff | blob | history
spec/acceptance/firewallchain_spec.rb diff | blob | history
spec/acceptance/ip6_fragment_spec.rb [new file with mode: 0644] blob
spec/acceptance/isfragment_spec.rb [new file with mode: 0644] blob
spec/acceptance/rules_spec.rb diff | blob | history
spec/acceptance/socket_spec.rb [new file with mode: 0644] blob
spec/spec_helper_acceptance.rb diff | blob | history