]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
mock.assert_called_once() is not a valid method
authorJacek Swiderski <jacek.swiderski@codilime.com>
Tue, 23 Sep 2014 12:35:06 +0000 (14:35 +0200)
committerJacek Swiderski <jacek.swiderski@codilime.com>
Mon, 13 Oct 2014 10:36:49 +0000 (12:36 +0200)
commite40c2ed58ce998fc5aba83ffae8ebefec9403c3b
treee2639a54f954a4a209d3b68ae02f3bb516d6d185
parent53b0e04ba195da36f4a45ae8fa5bb05ada04aa6d
mock.assert_called_once() is not a valid method

mock.assert_called_once() is a no-op that tests nothing. Instead
mock.assert_called_once_with() should be used (or use
assertEqual(1, mock_obj.call_count) if you don't want to check
parameters).

Borrowed HACKING rule from Davanum Srinivas's nova patch to
prevent it from appearing again.

Change-Id: Idac1d3c89c07e13c9a209663f4e557fcb7547821
Closes-Bug: #1365751
Closes-Bug: #1300265
HACKING.rst
neutron/hacking/checks.py
neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_mechanism_driver.py
neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_sync.py
neutron/tests/unit/services/l3_router/test_l3_apic_plugin.py
neutron/tests/unit/services/loadbalancer/drivers/radware/test_plugin_driver.py
neutron/tests/unit/test_hacking.py
neutron/tests/unit/test_l3_agent.py