]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Add hacking check for str and unicode in exceptions
authorJay S. Bryant <jsbryant@us.ibm.com>
Mon, 20 Apr 2015 23:05:47 +0000 (18:05 -0500)
committerJay S. Bryant <jsbryant@us.ibm.com>
Mon, 27 Apr 2015 21:27:52 +0000 (16:27 -0500)
commite3973fe20265ee6e8d9d85527858d2db516a3c91
tree0969091515c463b1a081f639de0958ff215c330c
parentfac178fd58f06c146d96711e454c9397a574d15f
Add hacking check for str and unicode in exceptions

One of the comments we are frequently having to make
on reviews is with regards to the use of str() or
unicode() on exceptions.  This hacking check pulled
from Nova will catch this problem earlier and avoid
conflicting comments being made in reviews.

Change-Id: I09eaf7b066f3e29733e6cbe16b2997edb6bc5e23
HACKING.rst
cinder/hacking/checks.py
cinder/tests/unit/api/v2/test_limits.py
cinder/tests/unit/test_glusterfs.py
cinder/tests/unit/test_hacking.py
cinder/tests/unit/test_quobyte.py
cinder/volume/drivers/nimble.py
cinder/volume/drivers/san/hp/hp_3par_common.py