]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove check for bash usage
authorMaru Newby <marun@redhat.com>
Tue, 7 Apr 2015 15:00:25 +0000 (15:00 +0000)
committerMaru Newby <marun@redhat.com>
Tue, 7 Apr 2015 15:15:33 +0000 (15:15 +0000)
commite37dcd4c76e3ab61c585b116c34d32382c592b9f
tree724c939a87d1b3162b4c7a41b2fa95b1a6745077
parent21bef562c23d96fe41daeedeb43c0bb2d1c53ed0
Remove check for bash usage

Arbitrarily restricting ourselves from using bash because developers on
platforms like netbsd don't want to install bash from ports doesn't
make sense.  Any non-trivial shell script is likely to use features
like arrays or string manipulation that are poorly supported (if at
all) by sh, and the continued bumping of the number of expected bash
scripts is an indication that the check is not serving its purpose
anyway.

Along with removing the check, all shebang references to /bin/bash
have been replaced with /usr/bin/env bash in an attempt to be more
compatible across different hosts.

Change-Id: Ief72dc380cc88af38959c330897e2c127e33c332
Closes-Bug: #1440824
13 files changed:
neutron/plugins/openvswitch/agent/xenapi/contrib/build-rpm.sh
neutron/tests/contrib/gate_hook.sh
neutron/tests/contrib/post_test_hook.sh
run_tests.sh
tools/abandon_old_reviews.sh
tools/check_unit_test_structure.sh
tools/clean.sh
tools/configure_for_func_testing.sh
tools/copy_api_tests_from_tempest.sh
tools/deploy_rootwrap.sh
tools/misc-sanity-checks.sh
tools/with_venv.sh
tox.ini