]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Introduce get_ports_attributes in OVSBridge
authorrossella <rsblendido@suse.com>
Thu, 9 Jul 2015 22:08:50 +0000 (22:08 +0000)
committerAssaf Muller <amuller@redhat.com>
Sun, 2 Aug 2015 10:42:07 +0000 (13:42 +0300)
commite32e74553fe4947c7e7cc011ce277f45a4514ef5
tree1f2cacf36fb08559855f917bb8da97a5c482e10d
parentdec8743b5398e7e038d7debb0d7c964947e0cd29
Introduce get_ports_attributes in OVSBridge

OVSBridge was inheriting db_list from BaseOVS, which was
returning the information of all the ports on the machine,
not only the ones belonging to the bridge.
The OVSNeutronAgent was using that method with the assumption
that ports were filtered by bridge.
To avoid confusion, this patch add a new method to OVSBridge
get_ports_attributes to query the info for all the ports
belonging to the bridge.
db_list is removed from BaseOVS since that method is already
available in ovsdb/api.py
ovs_lib methods that use db_list are refactored accordingly.

Co-Authored-By: Assaf Muller <amuller@redhat.com>
Change-Id: I2ce6d232744f48ba7fc0f824a7db32e3655bc2aa
Closes-Bug: 1473199
neutron/agent/common/ovs_lib.py
neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py
neutron/tests/functional/agent/test_ovs_lib.py
neutron/tests/unit/agent/common/test_ovs_lib.py
neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py
neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_tunnel.py