]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Fix issues with failed lvremove
authorJohn Griffith <john.griffith@solidfire.com>
Fri, 20 Sep 2013 20:55:46 +0000 (20:55 +0000)
committerJohn Griffith <john.griffith@solidfire.com>
Fri, 20 Sep 2013 21:00:47 +0000 (21:00 +0000)
commitde257d1a2b91e8060ff3532ced25cb2a67b14267
tree1d0bf41cb1a64fa99abe9720e0a779a6aa69539b
parent93fb1ac66fae8d22f91d46e327f32dda671548f5
Fix issues with failed lvremove

There are some race conditions that
can cause problems with lvremove commands.  In
most cases these seem to recover nicely just
with a simple retry of the lvremove.  Adding
a udev settle seems to elimate the rest of them.

This is a difficult issue to reproduce, and there's
a suspiscion that it relates to failed target
creeates.

The patch adds a catch on the lvremove failure,
followed by a udevadm settle and a retry of the
lvremove.  With the setup that I've been able
to reproduce this issue these changes have eliminated
any force delete failures.

The other option that had been proposed was using dmsetup remove
but there are concerns that this may cause problems.

Change-Id: I2a2b0d0f4fefd0daf9424ab96aaf87ba53ebc171
Closes-Bug: #1191960
cinder/brick/local_dev/lvm.py
cinder/volume/drivers/lvm.py
etc/cinder/rootwrap.d/volume.filters