]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Fix argument name mismatch in L3-RPC sync_routers
authorAkihiro MOTOKI <motoki@da.jp.nec.com>
Tue, 16 Jul 2013 08:05:19 +0000 (17:05 +0900)
committerMark McClain <mark.mcclain@dreamhost.com>
Wed, 17 Jul 2013 03:22:17 +0000 (23:22 -0400)
commitde1967452e935e8d78255c448715a588d19ae838
tree647e923e604fdb0965c7aa51712b6bc864b8dcfe
parent7750c38e12fa632f80ae05d5a2c7a5b561fa3788
Fix argument name mismatch in L3-RPC sync_routers

In sync_routers L3-RPC method l3-agent sends router_ids but the
server side expected router_id. This commit fixes the server side
to accept router_ids, and drops "fullsync" arg from the agent side
(fullsync is not used anywhere and it does not affect RPC signature).
This change allows l3-agent to sync only the specified routers
instead of all routers.

Fixes bug #1201553

As a result of the above change, auto_schedule_routers() and
list_active_sync_routers_on_active_l3_agent() in L3 scheduler
needs to handle a list of router IDs. This commit changes L3 scheduler
to accept a list of router IDs in the above two methods.

Also fixes the argument order of fullsync and router_ids in get_routers
in L3PluginApi. L3-agent main code expects router_ids as the second arg.

Change-Id: I22e8d11b9676cbcfe9e72449031bb63071be8314
neutron/agent/l3_agent.py
neutron/db/agentschedulers_db.py
neutron/db/l3_rpc_base.py
neutron/scheduler/l3_agent_scheduler.py
neutron/tests/unit/openvswitch/test_agent_scheduler.py