]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
IpsetManager refactoring
authorMiguel Angel Ajo <majopela@redhat.com>
Thu, 11 Sep 2014 15:05:57 +0000 (17:05 +0200)
committerMiguel Angel Ajo <mangelajo@redhat.com>
Sat, 6 Dec 2014 17:21:43 +0000 (18:21 +0100)
commitdcd4a11258d2cebbb2f08bd6386e2c8dac0039b2
treebf1d8e49807d114577955324e6fe984da8707588
parent988bd650d220b4c19b6275e4f0639e0ddceaea09
IpsetManager refactoring

Refactor the IpsetManager to move all the low level
knowledge about the ipset behaviour and performance
considerations from the firewall driver to the manager,
reduce redundant function names, and change missleading
variables talking about ipset chains, where they
should say ipset sets.

No logical changes to behaviour, just responsibilities
moved from one class to another.

Unit testing is move from iptables_firewall to ipset_manager
to test the new responsibilities of the class.

Implements: blueprint ipset-manager-refactor

Change-Id: I93000a37a71cd22753b32edbd0a5f3c9cb8b0bde
neutron/agent/linux/ipset_manager.py
neutron/agent/linux/iptables_firewall.py
neutron/tests/functional/agent/linux/test_ipset.py
neutron/tests/unit/agent/linux/test_ipset_manager.py [new file with mode: 0644]
neutron/tests/unit/test_iptables_firewall.py