]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Ensure unit tests do not let looping calls roam freely
authorSalvatore Orlando <salv.orlando@gmail.com>
Wed, 4 Sep 2013 19:22:23 +0000 (12:22 -0700)
committerSalvatore Orlando <salv.orlando@gmail.com>
Thu, 5 Sep 2013 00:19:21 +0000 (17:19 -0700)
commitdabbb1bfc567b06573b55a3e250cd3d5d98ade16
tree0359b43cb7b16fb451ae4e4a7c0ad63e147b8431
parent9b76de161d690faee341a87e8066d40329b4f5b0
Ensure unit tests do not let looping calls roam freely

Bug 1220871

This patch does minimal changes in neutron.plugins.nicira.common.sync
providing unit tests with a reference to the looping call object, so
that they can control its lifecycle.
Also, it perform a bit of refactoring in test_l3_agent.py in the way
mocks are created and started.

Change-Id: I73a1eb8ecdb7c6d46ff12afba549dd27095b7202
neutron/plugins/nicira/common/sync.py
neutron/tests/unit/nicira/test_nvp_sync.py
neutron/tests/unit/services/metering/test_metering_agent.py
neutron/tests/unit/services/vpn/test_vpn_agent.py
neutron/tests/unit/test_l3_agent.py