]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Fix usage of Query.all() and NoResultFound
authorRoman Podolyaka <rpodolyaka@mirantis.com>
Fri, 26 Apr 2013 15:27:39 +0000 (18:27 +0300)
committerRoman Podolyaka <rpodolyaka@mirantis.com>
Fri, 3 May 2013 13:24:57 +0000 (16:24 +0300)
commitdaaf2b6d6502da4f185ed65a21a75ab2aab2d1b7
tree171cb855477bbd9a5ced8b21f8e49e54a1d27f0e
parentf146ab58320f9dc5cfe86ede6f60823660a29fa5
Fix usage of Query.all() and NoResultFound

SQLAlchemy Query.all() method doesn't raise NoResultFound
exception in case if no result is found but rather returns
an empty list. So this pattern which is common for our code
doesn't make sense and should be fixed:

    try:
        dns_qry = context.session.query(models_v2.DNSNameServer)
        return dns_qry.filter_by(subnet_id=subnet_id).all()
    except exc.NoResultFound:
        return []

Fixes bug 1173131.

Change-Id: I19b64eecd6edac0dba7dd0bf2ab32690c46e4f8b
quantum/db/db_base_plugin_v2.py
quantum/plugins/cisco/db/api.py
quantum/plugins/cisco/db/l2network_db.py
quantum/plugins/cisco/db/network_db_v2.py
quantum/plugins/cisco/db/nexus_db_v2.py
quantum/plugins/openvswitch/ovs_db_v2.py