]> review.fuel-infra Code Review - openstack-build/heat-build.git/commit
Always validate auth_uri with allowed_auth_uris
authorSteve Baker <sbaker@redhat.com>
Mon, 19 Aug 2013 02:35:06 +0000 (14:35 +1200)
committerSteve Baker <sbaker@redhat.com>
Wed, 21 Aug 2013 23:10:21 +0000 (11:10 +1200)
commitda0313cf7b1591666d76b79615b2eccc78c67ffd
treec49d4c385fc0e857c15de36ad3381aa0b98ad7ad
parent044a8aaf69d9874edfafb1c7658055141545d1cc
Always validate auth_uri with allowed_auth_uris

The original intention was to allow heat to orchestrate
on any requested cloud when allowed_auth_uris is configured
with an empty list.

This change makes all requests be validated against
allowed_auth_uris for the following reasons:
- there is a potential security issue with requests
  being authorised by a fake keystone, allowing an exploit in
  heat to be executed without any valid authentication factors
  first being presented.
- ec2token middleware will also need to be made multi-cloud aware
  however as a compatible API it is not possible to specify the desired
  auth_uri with each request. Instead ec2token will need a list of
  configured endpoints so that it can try each one until a request
  is authenticated.

Change-Id: I3d6b7edf381a66b87b6e1fae07bc5dbe9db024bc
etc/heat/heat.conf.sample
heat/common/auth_password.py
heat/common/config.py
heat/tests/test_auth_password.py