]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Always run dnsmasq as root
authorHong Hui Xiao <xiaohhui@cn.ibm.com>
Thu, 2 Apr 2015 15:24:35 +0000 (08:24 -0700)
committerMatt Riedemann <mriedem@us.ibm.com>
Thu, 2 Apr 2015 20:09:30 +0000 (13:09 -0700)
commitd82366fe015c6be91d12f3b94fb65f9a03189109
tree636523dbf1cac16f43bf3e02b84fdb7450815c63
parent7904c9c969a7869788b4d21a8ed33d7ec693d077
Always run dnsmasq as root

Regarding https://review.openstack.org/#/c/145829/
The old code of DnsMasq will always get root_helper from
neutron.agent.dhcp.agent.
However, new code will only set run_as_root when namespace
is used. That will cause permission error when namespace
is disabled and dnsmasq need to be started.

Change-Id: Ib00d6e54dba44dbbbec158b9e0518e6e42baceec
Closes-Bug: #1428007
neutron/agent/linux/dhcp.py
neutron/agent/linux/external_process.py
neutron/agent/linux/ip_lib.py
neutron/tests/unit/agent/metadata/test_driver.py
neutron/tests/unit/test_linux_external_process.py
neutron/tests/unit/test_linux_ip_lib.py