]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove FWaaS Noop driver as default and move to unit tests dir
authorSridar Kandaswamy <skandasw@cisco.com>
Thu, 19 Dec 2013 08:04:25 +0000 (00:04 -0800)
committerSridar Kandaswamy <skandasw@cisco.com>
Thu, 19 Dec 2013 08:04:25 +0000 (00:04 -0800)
commitd7743bbdc3e992d9f9cceaeaa2919cd70b422364
treedcf27476af65fe4e3263deeaefb95ee57d11fdce
parenta7bdec1a31ffcc5a65f1802ed93c04d1cf2ace68
Remove FWaaS Noop driver as default and move to unit tests dir

Remove the FWaaS Noop driver as the default and raise an exception
when the fwaas_driver.ini file has an enabled flag without any
associated driver. This communicates a misconfiguration clearly.
The Noop driver is moved to unit tests where it is used.
Also some cleanups in related area.

Closes-Bug: #1250841

Change-Id: Ib6345923df05994ceffc0b1cbf265b53c23e97f1
neutron/services/firewall/agents/firewall_agent_api.py
neutron/services/firewall/agents/l3reference/firewall_l3_agent.py
neutron/services/firewall/drivers/fwaas_base.py
neutron/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py
neutron/tests/unit/services/firewall/agents/test_firewall_agent_api.py