]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Code Review / openstack-build / neutron-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: b318c2b) | patch
Unify using assertIsInstance
authorlzklibj <lzklibj@cn.ibm.com>
Wed, 6 Jan 2016 03:27:34 +0000 (11:27 +0800)
committerlzklibj <lzklibj@cn.ibm.com>
Thu, 14 Jan 2016 16:06:03 +0000 (00:06 +0800)
commitd2a1d6fcb7e746a5340db0990a8f5d0fc786738d
tree1a6f787666de18f327797077a0112732a5496a31tree | snapshot
parentb318c2b0e8f7e102d16a9dfef6a39fd95ab3d53ccommit | diff
Unify using assertIsInstance

Use assertIsInstance(A, B) to replace assertTrue(isinstance(A, B)).

Prefer specific assertions such as assert(Not)IsInstance over generic ones
(assertTrue/False, assertEqual) because they raise more meaningful errors.

Change-Id: I56278b1a74108e2765a8a740658f33954f5404c7
Closes-bug: #1268480
HACKING.rst diff | blob | history
neutron/hacking/checks.py diff | blob | history
neutron/tests/unit/hacking/test_checks.py diff | blob | history