]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Logging not using oslo.i18n guidelines (scheduler)
authorSean McGinnis <sean_mcginnis@dell.com>
Tue, 14 Apr 2015 15:02:22 +0000 (10:02 -0500)
committerSean McGinnis <sean_mcginnis@dell.com>
Wed, 22 Apr 2015 20:24:20 +0000 (15:24 -0500)
commitd0f243e0aee0df2627b6e6c28359152637414ea9
tree6cdb45b57e7493a0ae6abca0c1d6f331b1ff36c3
parentcbcbc90cf64d91a33b7bcfb826c59d4b69697486
Logging not using oslo.i18n guidelines (scheduler)

Multi-patch set for easier chunks. This one addresses
the scheduler cinder directory.

There have been quite a few instances found where the
i18n guidelines are not being followed. I believe this
has helped lead to some of the confusion around how to
correctly do this. Other developers see this code and
assume it is an example of the correct usage.

This patch attempts to clean up most of those violations
in the existing codebase to hopefully help avoid some of
that confusion in reviews.

Some issues address:
* Correct log translation markers for different log levels
* Passing format values as arguments to call, not preformatting
* Not forcing translation via six.text_type and others

Guidelines can be found here:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html

Hacking checks will not be able to identify all violations of
the guidelines, but it could be useful for catching obvious
one such as LOG.info("No markers!").

Change-Id: I0473ac402bc7b4a644c9b700df0fa2b88d82d705
Partial-bug: 1433216
cinder/hacking/checks.py
cinder/scheduler/evaluator/evaluator.py
cinder/scheduler/filter_scheduler.py
cinder/scheduler/flows/create_volume.py
cinder/scheduler/host_manager.py
cinder/scheduler/manager.py
cinder/scheduler/scheduler_options.py
cinder/tests/unit/scheduler/test_host_manager.py
cinder/tests/unit/scheduler/test_scheduler.py