]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Don't emit confusing error in netns-cleanup
authorAssaf Muller <amuller@redhat.com>
Mon, 7 Dec 2015 22:36:06 +0000 (17:36 -0500)
committerAssaf Muller <amuller@redhat.com>
Tue, 8 Dec 2015 01:17:49 +0000 (20:17 -0500)
commitcfc9578148985f117c230be263d9faab4c1bb57e
tree23c9d218204e15e8fa160016df9f291889740637
parentc58b8d5eaaacf172f4709cf15ac48ce5fb7f4bb5
Don't emit confusing error in netns-cleanup

If we're trying to delete a dhcp/qrouter device with use_veth
= False (Which is the default for some time), we'll first
try to 'ip link del %s', which will fail and emit a confusing
error, then try 'ovs-vsctl del-port'. There's no need to
log an error in such a case.

The patch attempts to future proof by setting the
set_log_fail_as_error(False) to be as tight as possible, so we
do log errors in case the device is somehow used in the future.

Change-Id: I1954bde3ee9a2e43d7615717134b61c5fa7cfbb1
Closes-Bug: #1463800
neutron/cmd/netns_cleanup.py