]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Plugins should call __init__ of db_base_plugin for db.configure
authorAaron Rosen <aaronorosen@gmail.com>
Wed, 19 Feb 2014 23:08:54 +0000 (15:08 -0800)
committerThomas Goirand <thomas@goirand.fr>
Thu, 13 Mar 2014 07:20:27 +0000 (15:20 +0800)
commitcc67dc14d8510569c87eb63243cf61ade96a1c09
tree3a71348a959673b2b246c278e8244041bed02a3d
parent2df5ecad274f0ee029d577e48d8f49bf96e4ba66
Plugins should call __init__ of db_base_plugin for db.configure

Currently each plugin calls db.configure() within the plugin's __init__
class or defines an initialize() method that's sole job is to call this
method. Instead we should just call the super method of a plugin so that
db.configure() is called for us out of the db_base_plugin class.

Note: the only reason why I'm making this change is that I want to add
something to the __init__() class of the db_base_plugin that's needed for
the nova-event-callback blueprint and adding it in the base class of init
looks to be the best place.

Change-Id: Iec3c912735021ceb90f657108aad3a57460d66e7
Closes-bug: #1282303
30 files changed:
neutron/db/db_base_plugin_v2.py
neutron/plugins/bigswitch/plugin.py
neutron/plugins/brocade/NeutronPlugin.py
neutron/plugins/cisco/db/n1kv_db_v2.py
neutron/plugins/cisco/n1kv/n1kv_neutron_plugin.py
neutron/plugins/linuxbridge/db/l2network_db_v2.py
neutron/plugins/linuxbridge/lb_neutron_plugin.py
neutron/plugins/metaplugin/meta_neutron_plugin.py
neutron/plugins/metaplugin/proxy_neutron_plugin.py
neutron/plugins/midonet/plugin.py
neutron/plugins/ml2/db.py
neutron/plugins/ml2/plugin.py
neutron/plugins/mlnx/db/mlnx_db_v2.py
neutron/plugins/mlnx/mlnx_plugin.py
neutron/plugins/nec/db/api.py
neutron/plugins/nec/nec_plugin.py
neutron/plugins/nicira/NeutronPlugin.py
neutron/plugins/openvswitch/ovs_db_v2.py
neutron/plugins/openvswitch/ovs_neutron_plugin.py
neutron/plugins/plumgrid/plumgrid_plugin/plumgrid_plugin.py
neutron/plugins/ryu/ryu_neutron_plugin.py
neutron/tests/unit/cisco/n1kv/test_n1kv_db.py
neutron/tests/unit/cisco/n1kv/test_n1kv_plugin.py
neutron/tests/unit/linuxbridge/test_lb_db.py
neutron/tests/unit/ml2/test_type_gre.py
neutron/tests/unit/ml2/test_type_vxlan.py
neutron/tests/unit/mlnx/test_mlnx_db.py
neutron/tests/unit/nec/test_ofc_manager.py
neutron/tests/unit/openvswitch/test_ovs_db.py
neutron/tests/unit/test_quota_ext.py