]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Add SIGHUP handlers to reset RPC version pins
authorMichał Dulko <michal.dulko@intel.com>
Fri, 5 Feb 2016 14:41:01 +0000 (15:41 +0100)
committerMichał Dulko <michal.dulko@intel.com>
Fri, 19 Feb 2016 09:30:17 +0000 (10:30 +0100)
commitc9a55d852e3f56a955039e99b628ce0b1c1e95af
treec4e42c85e955f3135f0d0153084c4bcf573d1deb
parent3631fd257655a165bceb7e30c644e389be1fc73b
Add SIGHUP handlers to reset RPC version pins

Adding SIGHUP handlers (by implementing reset from oslo.service) to
cinder-scheduler, cinder-backup and cinder-volume that reset cached RPC
version pins. This is to avoid the need to restart all the services when
upgrade of the deployment is completed.

Some changes go a little deep into the stack, because to reload all the
pins we need to recreate <service>.rpcapi.<service>API objects that are
stored in the memory.

Please note that SIGHUP signal is handled by oslo.service only when
service runs in daemon mode (without tty attached). To test this commit
in DevStack you need to add "&" to the end of the command that starts
the service.

Situation is more complicated with the API service, so we're leaving it
with restart required for now. In the deployments with HA cinder-api is
typically behind a load balancer, so restarting individual nodes
one-by-one should be easy.

DocImpact: Add information on rolling upgrades procedures to the docs.
Implements: blueprint rpc-object-compatibility

Change-Id: I03ed74e17dc9a4b9aa2ddcfbeb36a106a0f035f8
cinder/backup/manager.py
cinder/manager.py
cinder/scheduler/driver.py
cinder/scheduler/manager.py
cinder/service.py
cinder/tests/unit/scheduler/test_scheduler.py
cinder/tests/unit/test_backup.py
cinder/tests/unit/test_service.py
cinder/tests/unit/test_volume.py
releasenotes/notes/rpc_compatibility-375be8ac3158981d.yaml [new file with mode: 0644]