]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
GRE tunnels should include local_ip.
authorAdin Scannell <adin@scannell.ca>
Mon, 27 May 2013 17:21:42 +0000 (13:21 -0400)
committerAdin Scannell <adin@scannell.ca>
Thu, 18 Jul 2013 14:38:58 +0000 (10:38 -0400)
commitc98ec249614b44d8e1a44cb07903338c3056e772
treeabd90528b45bfcc9db1d7c942cb239591dbfcbe0
parenta8e4cb916ca94a442f2104696707267b1d680de4
GRE tunnels should include local_ip.

This addresses the issue of having one or more multi-homed host.

Because you may only specify one local IP for a quantum agent, and
other hosts could be routed across different subnets (even for small
installations, for various reasons), it's important to also specify
the used local_ip when setting up the GRE tunnels. As long as the
address is routable on both ends, this will work. If the local_ip is
not specified, then traffic will mysteriously be dropped on one end
where the IP does not match the expected IP in the GRE tunnel.

Bug: https://bugs.launchpad.net/quantum/+bug/1184696

Change-Id: I5d612bf9e4f6652af8b155cdd1748d73ac4539ff
Signed-off-by: Adin Scannell <adin@scannell.ca>
neutron/agent/linux/ovs_lib.py
neutron/plugins/openvswitch/agent/ovs_neutron_agent.py
neutron/tests/unit/openvswitch/test_ovs_lib.py
neutron/tests/unit/openvswitch/test_ovs_tunnel.py