]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Code Review / openstack-build / cinder-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: c4702d8) | patch
Tidy up the SSH call to avoid injection attacks for HP's driver
authorHaomai Wang <haomai@unitedstack.com>
Thu, 18 Jul 2013 15:05:43 +0000 (23:05 +0800)
committerHaomai Wang <haomai@unitedstack.com>
Wed, 14 Aug 2013 05:59:07 +0000 (13:59 +0800)
commitc55589b131828f3a595903f6796cb2d0babb772f
treed7d2f467743415f0f51ad6a9fd1e79f05c642e8dtree | snapshot
parentc4702d8b7365ec58c5353075f571e2b3d89ec9e3commit | diff
Tidy up the SSH call to avoid injection attacks for HP's driver

Let the command and arguments form up a list and avoid the extra arguments
attackers inserted to the command string.

And modify the interface of _cli_run, there is no need for a extra argument.

fix bug 1192971
Change-Id: Iff6a3ecb64feccae1b29164117576cab9943200a
cinder/tests/test_hp3par.py diff | blob | history
cinder/volume/drivers/san/hp/hp_3par_common.py diff | blob | history
cinder/volume/drivers/san/hp/hp_3par_fc.py diff | blob | history
cinder/volume/drivers/san/hp/hp_3par_iscsi.py diff | blob | history
cinder/volume/drivers/san/hp_lefthand.py diff | blob | history