]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove check on dhcp enabled subnets while scheduling dvr
authorSwaminathan Vasudevan <swaminathan.vasudevan@hp.com>
Wed, 25 Nov 2015 23:15:17 +0000 (15:15 -0800)
committerlzklibj <lzklibj@cn.ibm.com>
Wed, 23 Dec 2015 15:16:15 +0000 (23:16 +0800)
commitc2483b73c2ca6586d7b169511be50f85230fd0f7
treeb692e6c81a33e156a4c6c771097dd91345d1b676
parenta5b22858b826ef766aff41e200feada2a05b517d
Remove check on dhcp enabled subnets while scheduling dvr

In check_ports_exist_on_l3agent we have an optimization fix
that checks for the subnets associated with the router and if
the subnets have dhcp enabled we go ahead and create the
router if it is a dvr_snat agent.

This was introduced in liberty since we saw some race condition
in the gate with single node failures.
It may not be completely right, since the dhcp agents can
run on non dvr_snat nodes as well.

Based on recommendation from the reviews, and a recent upstream
patch that sends notification on port create, we would want to
remove this and monitor the situation.

This would reduce the load on check_ports_exist_on_l3agent for
non dvr_snat nodes.

Depends-On: I40b8684f6ec9ddd31753f7bbbdb364d1c0ec838a
Related-Bug: #1513678

Change-Id: I0f50dc1101b2013caf03a64a4f48e2d03ea87b26
neutron/db/l3_agentschedulers_db.py
neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py
neutron/tests/unit/db/test_agentschedulers_db.py
neutron/tests/unit/scheduler/test_l3_agent_scheduler.py