]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove some duplicate unit tests
authorKevin Benton <blak111@gmail.com>
Thu, 18 Sep 2014 13:52:13 +0000 (06:52 -0700)
committerKevin Benton <blak111@gmail.com>
Sat, 11 Oct 2014 01:26:14 +0000 (18:26 -0700)
commitc19a227c0eda5c88a4e0de78878dc6332167c14e
treecee8a1cacecc678d650a10a69ac798fcadd247a2
parente95c76bd983387727144b36c032d9b161ff4826d
Remove some duplicate unit tests

There are several locations where some unit test mixins are
incorrectly used multiple times with an otherwise same configuration,
which results in pointless re-runs of the same unit test. Similarily,
there are a few tests defined in classes inherited by multiple tests
that don't change behavior in the child tests so they are run multiple
times as well.

This patch eliminates the duplicates and moves some test cases from
their parent class into a subclass when they don't need to be run multiple
times. The result is 221 fewer test runs (~1.5% of the tests run).

Closes-Bug: #1374836
Change-Id: I292091488cd944510fa1250920d41be2a50dabaf
neutron/tests/unit/cisco/n1kv/test_n1kv_plugin.py
neutron/tests/unit/embrane/test_embrane_l3_plugin.py
neutron/tests/unit/ml2/drivers/mech_sriov/test_mech_sriov_nic_switch.py
neutron/tests/unit/ml2/drivers/test_mech_mlnx.py
neutron/tests/unit/ml2/test_mechanism_odl.py
neutron/tests/unit/nuage/test_nuage_plugin.py
neutron/tests/unit/nuage/test_syncmanager.py