]> review.fuel-infra Code Review - openstack-build/heat-build.git/commit
Emit alarm actions if a rule remains in ALARM state.
authorSteve Baker <sbaker@redhat.com>
Mon, 24 Jun 2013 02:19:36 +0000 (14:19 +1200)
committerSteve Baker <sbaker@redhat.com>
Mon, 24 Jun 2013 02:19:36 +0000 (14:19 +1200)
commitbdeb33afdc52f37c2270a72c2221b051024f3f3f
treed93f77df69050893243ebebeafbcd4e4071d2dee
parent2c7e4fd15466696844b53fbbad67bbd183dd38a2
Emit alarm actions if a rule remains in ALARM state.

It looks like the original intent of this edge-triggering was to
prevent actions being emitted too frequently, causing overshoot of
scaling resources.

However this causes an issue when one scaling resource change is not
enough to bring the alarm state under the threshold.

Proper use of Period, EvaluationPeriods and Threshold should be sufficient
to prevent scaling resource overshoot.

Fixes bug: #1193970

Change-Id: I5b38eb82cd1ad568fe4af77999e9d52f9eb99328
heat/engine/watchrule.py
heat/tests/test_watch.py