]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Revert "Fix Brocade FC SAN lookup MITM vulnerability"
authorJay S. Bryant <jsbryant@us.ibm.com>
Tue, 2 Dec 2014 20:35:06 +0000 (14:35 -0600)
committerThomas Goirand <thomas@goirand.fr>
Sun, 14 Dec 2014 09:18:31 +0000 (09:18 +0000)
commitbb7b082c44679f53cd0afc289b624af4d8ea2890
tree2dc9bb82e791352aef763dcf660ccc219a9704ea
parent81e336699e85bdcda8b0dfa8fbaa465d8708ea3c
Revert "Fix Brocade FC SAN lookup MITM vulnerability"

This reverts commit ab4f57212683baec45d5b682bdd3952ff58249ed.

The change is being reverted as it broke the Brocade FC SAN lookup
functionality.  The change uses configuration options from
ssh_utils that are not initialized when the Brocade driver is
run causing an exception to be thrown complaining that
CONF.ssh_hosts_key_file is used before it is initialized.

The right solution is to change the Brocade driver to use ssh_utils to
make SSH connections.

Conflicts:

cinder/zonemanager/drivers/brocade/brcd_fc_san_lookup_service.py

Change-Id: I7814c3da9c0e6fcf3143969e74304a48cafcb3d1
Closes-bug: 1398488
(cherry-picked from commit 57103807c5e7fad7276f97ac82f8704f17f4b846)
cinder/tests/zonemanager/test_brcd_fc_san_lookup_service.py
cinder/zonemanager/drivers/brocade/brcd_fc_san_lookup_service.py