]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commit
(#14463) Fix to pass unit tests
authorSharif Nassar <sharif@mediatemple.net>
Tue, 27 Nov 2012 22:32:46 +0000 (14:32 -0800)
committerDan Carley <dan.carley@gmail.com>
Thu, 29 Nov 2012 17:22:11 +0000 (17:22 +0000)
commitb4d2e071376f861f61136bba8b2c9add9d8d0637
treec187f1f6aef08a9a5342d9cc00b89b767444cafd
parent53d3ef9da087b684331601fd112f57b13f931c6a
(#14463) Fix to pass unit tests

* Add default protocol to fix the test for converting a string 'ssh' to a port
number was failing like so:
  1) Puppet::Type::Firewall dport should convert a port name for dport to its number
     Failure/Error: @resource[port] = 'ssh'
     Puppet::Error:
       Parameter dport failed: Munging failed for value "ssh" in class dport: no such service ssh/proto
     # ./lib/puppet/type/../../puppet/util/firewall.rb:84:in `getservbyname'
     # ./lib/puppet/type/../../puppet/util/firewall.rb:84:in `string_to_port'
     # ./lib/puppet/type/firewall.rb:164:in `unsafe_munge'
     # ./spec/unit/puppet/type/firewall_spec.rb:161

* Always convert the response .to_s
lib/puppet/util/firewall.rb