]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Fix incorrect exception order in _execute_request
authorAngus Lees <gus@inodes.org>
Mon, 25 Aug 2014 02:02:16 +0000 (12:02 +1000)
committerAngus Lees <gus@inodes.org>
Thu, 27 Nov 2014 05:44:44 +0000 (16:44 +1100)
commitb0d763e92218391aae51b205f303a4d6712d87d7
tree151ae7ff4d271d1a6efd21d45bc6ed9e425c8c72
parentef86198181649f13da9692b6a2b339e36901aa27
Fix incorrect exception order in _execute_request

_execute_request has a list of exception handlers to log various types
of errors with more specific error messages. Unfortunately, it catches
requests.exceptions.ConnectionError before requests.exceptions.SSLError,
but ConnectionError is a superclass of SSLError so the latter is never
invoked.

This change corrects the exception handling order, and enables the
bad-except-order pylint check now that the check passes.

Change-Id: I92bacd6088de5cbc170bc5c081a1db1baeec69e7
Closes-Bug: #1360970
.pylintrc
neutron/services/loadbalancer/drivers/netscaler/ncc_client.py