]> review.fuel-infra Code Review - openstack-build/heat-build.git/commit
Only validate credentials on create based on resources
authorSteve Baker <sbaker@redhat.com>
Fri, 30 Aug 2013 05:21:56 +0000 (17:21 +1200)
committerSteve Baker <sbaker@redhat.com>
Thu, 5 Sep 2013 23:42:36 +0000 (11:42 +1200)
commitaf238fbd081f7c14016d923c3924a648963fdeca
tree54d7438f0ee3aa7a26afbfa3cdbd0009e5e9235b
parent8a0043f5d63c7f918eb103d7922ff6a1c2c5d588
Only validate credentials on create based on resources

This change relaxes the validation which checked for credentials
on stack create and update.

As implemented, having any of the following resources
in the template will result in credentials being mandatory
on create and update:
* AWS::AutoScaling::ScalingPolicy
* OS::Heat::HARestarter
* AWS::CloudFormation::WaitConditionHandle

For all other templates, credentials are not needed.

When trusts are merged, this logic could also be used to decide
whether a trust token needs to be created at all.

Fixes bug: #1217617

Change-Id: I3e4b8698d3712053dc3c0851433ef0cbbadbdfed
heat/engine/parser.py
heat/engine/resource.py
heat/engine/service.py
heat/engine/signal_responder.py
heat/tests/test_engine_service.py
heat/tests/test_parser.py
heat/tests/test_signal.py