]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Catch broad exception in methods used in FixedIntervalLoopingCall
authorEugene Nikanorov <enikanorov@mirantis.com>
Tue, 26 May 2015 16:17:20 +0000 (20:17 +0400)
committerEugene Nikanorov <enikanorov@mirantis.com>
Tue, 2 Jun 2015 23:42:30 +0000 (03:42 +0400)
commitae8c1c5f80fd4fb7b4ab116677f4cff988c67cf1
tree30a3befd4e8d89fff86e77520bc25a8e3a8a3d8c
parentdee9ffc69667775321c6c5d4a83586b04a2c0c86
Catch broad exception in methods used in FixedIntervalLoopingCall

Unlike other places where it might make sense to catch specific
exceptions, methods that are used to check L3 and DHCP agents
liveness via FixedIntervalLoopingCall should never allow exceptions
to leak to calling method and interrupt the loop.

Further improvement of FixedIntervalLoopingCall might be needed,
but for the sake of easy backporting it makes sense to fix the issue
in neutron before pushing refactoring to 3rd-party library.

Change-Id: I6a61e99a6f4e445e26ea4a9923b47e35559e5703
Closes-Bug: #1458119
neutron/db/agentschedulers_db.py
neutron/db/l3_agentschedulers_db.py
neutron/tests/unit/plugins/openvswitch/test_agent_scheduler.py
neutron/tests/unit/scheduler/test_dhcp_agent_scheduler.py