]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Add key manager implementation with static key
authorJoel Coffman <joel.coffman@jhuapl.edu>
Tue, 24 Sep 2013 23:10:09 +0000 (19:10 -0400)
committerJohn Griffith <john.griffith@solidfire.com>
Thu, 3 Oct 2013 03:48:29 +0000 (21:48 -0600)
commitae6b7642e8d32ef5fa75cdcfe55be23c052fd547
treea280c0ba60bf623d9e37a012ce8cc60dd294a33f
parentddc585678df8899b42c6d704a848281caa11967d
Add key manager implementation with static key

Per feedback received on other patch sets, an example key manager
driver is required to support ephemeral storage encryption and
Cinder volume encryption -- see
* https://blueprints.launchpad.net/nova/+spec/encrypt-cinder-volumes
* https://blueprints.launchpad.net/nova/+spec/encrypt-ephemeral-storage
The ConfKeyManager class reads its key from the project's
configuration file and provides this key for *all* requests. As
such, this key manager is insecure but allows the aforementioned
encryption features to be used without further integration effort.

To clarify the above statements, the configuration-based key
manager uses a single, fixed key. When used to encrypt data (e.g.,
by the Cinder volume encryption feature), the encryption provides
limited protection for the confidentiality of data. For example,
data cannot be read from a lost or stolen disk, and a volume's
contents cannot be reconstructed if an attacker intercepts the iSCSI
traffic between the compute and storage host. If the key is ever
compromised, then any data encrypted with the key can be decrypted.

This commit copies the ConfKeyManager class from Nova as well as
synchronizing changes with the key manager interface in Nova.

Implements blueprint encrypt-cinder-volumes
DocImpact
SecurityImpact

Change-Id: I5cb06386410f46cabc490fa6af23272d1d2cb979
cinder/exception.py
cinder/keymgr/__init__.py
cinder/keymgr/conf_key_mgr.py [new file with mode: 0644]
cinder/keymgr/key.py
cinder/tests/conf_fixture.py
cinder/tests/keymgr/mock_key_mgr.py
cinder/tests/keymgr/test_conf_key_mgr.py [new file with mode: 0644]
cinder/tests/keymgr/test_key.py
cinder/tests/keymgr/test_key_mgr.py
etc/cinder/cinder.conf.sample