]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Rename/move/remove HaRouter methods
authorAssaf Muller <amuller@redhat.com>
Wed, 25 Mar 2015 00:27:29 +0000 (20:27 -0400)
committerAssaf Muller <amuller@redhat.com>
Wed, 25 Mar 2015 15:40:10 +0000 (11:40 -0400)
commitac95db26f3b394064e7bb16df7aaaee6b4f63d5a
tree96e8a7cdeb0439f798604ef924e0170eb968aea8
parent97372fe6ff1ac620927bba0c2e9d0dfdb012c93d
Rename/move/remove HaRouter methods

All of the methods that use verify_ha are now part of the HaRouter
class. The check has outlived its usefulness and may die
a peaceful yet horrifying death. At its point of death,
verify_ha is akin to a guy walking down the street and yelling:
'Am I me? Am I me?' - Yes, you're you, shut up. An HA router
is an HA router, there's no point in the class checking if
it's indeed an HA router.

* keepalived_manager._get_full_config_file_path was being used
  outside of the keepalived_manager, removed the leading underscore
* _ha_get_existing_cidrs doesn't need an 'ha' prefix, it's already
  a part of the HA router class. This patch renames the method to
  a more descriptive name
* HARouter._get_ipv6_lladdr had nothing to do with HA routers, nor
  did it use the HARouter state. Moved it to ip_lib

Partially-Implements: bp/restructure-l3-agent
Change-Id: I6a7df0b08ca3fc8c2c1b310aa8dd897111f52974
neutron/agent/l3/ha_router.py
neutron/agent/linux/ip_lib.py
neutron/agent/linux/keepalived.py
neutron/tests/functional/agent/test_l3_agent.py
neutron/tests/unit/agent/l3/test_ha_router.py
neutron/tests/unit/test_l3_agent.py