]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Fix a copy/pasted test mistake
authorRussell Bryant <rbryant@redhat.com>
Mon, 17 Nov 2014 21:33:06 +0000 (21:33 +0000)
committerRussell Bryant <rbryant@redhat.com>
Wed, 19 Nov 2014 17:18:34 +0000 (17:18 +0000)
commitab40ef64063b19739b8558feaee828f71e91eb56
treee29e82ea3405fee15032edef900b4b875b6baabc
parent33feefb553a76d52624875c08fd12b3914f00727
Fix a copy/pasted test mistake

Fix a minor test mistake that was copied around a few times.  In mock
setup, the intention was to only return a value of the rpc method used
was a 'call', not 'cast'.  Unfortunately, the variable checked was
method instead of rpc_method, so this expected return was always set
to None.

This also points out that what's being tested here isn't what *really*
was intended.  It ends up testing that the code returns what we mocked
it to return, which isn't all that useful.  However, at least with
this fix it's a bit more clear what it's trying to do.

Change-Id: I18e85aa66f83331318177d70cbae2468ff8bb57d
neutron/tests/unit/hyperv/test_hyperv_rpcapi.py
neutron/tests/unit/ml2/test_rpcapi.py
neutron/tests/unit/mlnx/test_rpcapi.py