]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Fix 500 error on invalid security-group-rule creation for NVP
authorarmando-migliaccio <amigliaccio@nicira.com>
Tue, 20 Aug 2013 23:51:29 +0000 (16:51 -0700)
committerarmando-migliaccio <amigliaccio@nicira.com>
Thu, 22 Aug 2013 00:00:38 +0000 (17:00 -0700)
commita8c064ed322bf92a867a42b99a5b94cfef137a3d
treefbafdf04d940645b173e06997e972be790c27e31
parent589071a1fb1a783198bfe2da4e5c1213adbc9c1a
Fix 500 error on invalid security-group-rule creation for NVP

Validate that, when creating rules specifying a protocol different
from TCP, UDP, ICMP and ICMPv6, no port (range) is specified because
NVP does not like it.

The extra validation is specific to the NVP plugin because other
plugins may choose a different failure mode. For example, the ovs
plugin does not complain at all, but it just ignores the port range
if the protocol is not a port-oriented one.

Fixes bug #1213293

Change-Id: I46e9032b5cf7f7d88b9d05c3bf020784b04217d9
neutron/common/constants.py
neutron/db/securitygroups_db.py
neutron/plugins/nicira/NeutronPlugin.py
neutron/tests/unit/nicira/test_nicira_plugin.py
neutron/tests/unit/test_extension_security_group.py