]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove usage of locals() for formatting from cinder.volume.*
authorHaomai Wang <haomai@unitedstack.com>
Sun, 16 Jun 2013 05:21:20 +0000 (13:21 +0800)
committerHaomai Wang <haomai@unitedstack.com>
Sun, 16 Jun 2013 15:59:29 +0000 (23:59 +0800)
commita80003cd49282a41fa313a679e72d237ef51c76e
tree3edd368f323302aadbe9fa003af0f6f454d33dc7
parent0e249f4b9a20e39e4758476994576a0ec3f65745
Remove usage of locals() for formatting from cinder.volume.*

Using of locals() for formatting string is a nasty thing because:
1) It is not so clear as using explicit dicts
2) It could produce hidden errors during refactoring
3) Changing name of variable causes change in message
4) Creating a lot of unused variables

Fix bug 1171936

Change-Id: I806c530851527db9da251352be45b97c183241a8
cinder/volume/drivers/emc/emc_smis_common.py
cinder/volume/drivers/glusterfs.py
cinder/volume/drivers/netapp/iscsi.py
cinder/volume/drivers/netapp/nfs.py
cinder/volume/drivers/nfs.py
cinder/volume/drivers/san/hp/hp_3par_common.py
cinder/volume/drivers/san/hp_lefthand.py
cinder/volume/drivers/san/solaris.py
cinder/volume/drivers/zadara.py
cinder/volume/manager.py