]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
brocade: Use lazy logging interpolation
authorAngus Lees <gus@inodes.org>
Mon, 22 Dec 2014 04:41:01 +0000 (15:41 +1100)
committerAngus Lees <gus@inodes.org>
Mon, 22 Dec 2014 06:12:54 +0000 (17:12 +1100)
commita70a38fc8c23461a08ecadb113d2c54eb4e5bbc4
tree1aba376be28529445f605dbb5623a0d7b8d17d9a
parent4a5a8aab0f6a451642b459cdc510edb4e36a9858
brocade: Use lazy logging interpolation

There are a small number of examples of "eager" interpolation in
neutron:
  logging.debug("foo %s" % arg)

These should be converted to perform the interpolation lazily within
the logging function, since if the severity is below the logging level
then the interpolation can be skipped entirely.

This change addresses all such examples found in brocade
l3_router_plugin via a pylint test.  Other occurrences are addressed
elsewhere.

Change-Id: Ia2d51e8ecbc7af81390577ec69c5ce18523b65f3
Partial-Bug: #1404788
neutron/services/l3_router/brocade/l3_router_plugin.py