]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Removed eval of unchecked strings.
authorMaru Newby <mnewby@internap.com>
Tue, 18 Sep 2012 01:46:38 +0000 (18:46 -0700)
committerMaru Newby <mnewby@internap.com>
Mon, 17 Sep 2012 16:11:43 +0000 (09:11 -0700)
commita6fbe838954ebc9432da58322ddece3ae47178c0
treeddbf2a99da278fd96cfcac4535a0414ae19620be
parent393ee84625f7d0b8d66e45bfb3eceb77c76db1d4
Removed eval of unchecked strings.

 * eval() was previously used to marshall unchecked strings as
   filter parameters for QuantumDbPluginV2.get_ports() via
   the --fixed_ips flag.
 * This change removes the use of eval and cleans up the filtering
   implementation for get_ports().
 * The new filtering implementation does not support arbitrary
   OR'ing or AND'ing.  Instead, multiple values for a given filter
   key are logically OR'ed, and filters across keys are AND'ed.
 * Example usage - filter for .2 or .3 in the given subnet:

     quantum port-list -- --fixed_ips ip_address=10.0.0.3 \
         ip_address=10.0.0.2 subnet_id=nOtaRealId

 * Addresses bug 1052179

Change-Id: I451f33ae53e623f86015b3fc2e6a7ca2f51ee836
quantum/api/v2/attributes.py
quantum/api/v2/base.py
quantum/db/db_base_plugin_v2.py
quantum/tests/unit/test_api_v2.py
quantum/tests/unit/test_attributes.py
quantum/tests/unit/test_db_plugin.py