]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Cisco: unsupported format character in log format
authorAngus Lees <gus@inodes.org>
Wed, 17 Dec 2014 04:44:12 +0000 (15:44 +1100)
committerAngus Lees <gus@inodes.org>
Wed, 17 Dec 2014 04:44:12 +0000 (15:44 +1100)
commita1a908e815f27f630bc7a7a5dfc06031cfc2bf3b
treed64eca98322f104d23318167b267aabc3112ea2d
parentfffc6e4712328574a8fe42d7b7520c0dace2b6b7
Cisco: unsupported format character in log format

CiscoCfgAgent.hosting_devices_removed() contains an error in the
format string used to log errors:

    LOG.error(_LE("Invalid payload format for received RPC message "
"`hosting_devices_removed`. Error is %{error}s. "
"Payload is %(payload)s"),
      {'error': e, 'payload': payload})

"%{error}s" should be "%(error)s"

The existing version raises "ValueError: unsupported format character
'{' (0x7b)" when invoked.

(found via pylint)

Change-Id: Ic5e9db2a19aa7652cbbd1ee04d7e02914e8d0093
Closes-Bug: #1403304
neutron/plugins/cisco/cfg_agent/cfg_agent.py