]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Only use operational LIFs for iscsi target details
authorTom Barron <tpb@dyncloud.net>
Wed, 25 Mar 2015 15:28:08 +0000 (11:28 -0400)
committerTom Barron <tpb@dyncloud.net>
Wed, 1 Apr 2015 15:38:50 +0000 (15:38 +0000)
commit9d77c0e1435d377790eaf812691b29e8b7a6b2c7
tree0106b5fe6a1c7747026b6fafa023de785c8e205a
parent00ca77befeb38adc58b140fb3c445e9f91cfd30f
Only use operational LIFs for iscsi target details

When Nova invokes our cDOT driver's initialize_connection() method
in order to attach an iSCSI volume to an instance, we have been
returning the first target from the list of targets returned from
the filer API call to get iscsi target details.  In failover mode,
this may be a target with a LIF that is down, causing the attach
attempt to fail in Nova.

This commit fixes that issue so that attaches still work in
failover by returning the first target with an *operational* LIF.

Closes-bug: 1437419

Change-Id: I3f53c3644f7d94f5188151c16d70e565b745ad4a
12 files changed:
cinder/tests/test_netapp.py
cinder/tests/volume/drivers/netapp/dataontap/client/fakes.py [new file with mode: 0644]
cinder/tests/volume/drivers/netapp/dataontap/client/test_client_cmode.py
cinder/tests/volume/drivers/netapp/dataontap/fakes.py
cinder/tests/volume/drivers/netapp/dataontap/test_block_7mode.py
cinder/tests/volume/drivers/netapp/dataontap/test_block_base.py
cinder/tests/volume/drivers/netapp/dataontap/test_block_cmode.py
cinder/volume/drivers/netapp/dataontap/block_7mode.py
cinder/volume/drivers/netapp/dataontap/block_base.py
cinder/volume/drivers/netapp/dataontap/block_cmode.py
cinder/volume/drivers/netapp/dataontap/client/client_base.py
cinder/volume/drivers/netapp/dataontap/client/client_cmode.py