]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Do not assume order of parameters in OVSBridge.add_flow call
authorIlya Shakhat <ishakhat@mirantis.com>
Fri, 8 Aug 2014 12:48:22 +0000 (16:48 +0400)
committerIlya Shakhat <ishakhat@mirantis.com>
Fri, 8 Aug 2014 14:07:51 +0000 (18:07 +0400)
commit9ce1935d06b2822a34ffb1234bc994acf306ad32
tree4d5707634791f40076c58220eef9d635156a42a5
parentec3f1761791c998a89a85d8c8b45cbfba9d54a47
Do not assume order of parameters in OVSBridge.add_flow call

This fixes neutron.tests.unit.agent.linux.test_ovs_lib.OVS_Lib_Test.test_add_flow
unit test that breaks with a randomized PYTHONHASHSEED.

The test assumed that the parameters passed to add_flow had
elements in a particular order. Found with PYTHONHASHSEED=2455351445.
The fix refactors the test case to match parameters as set.

Partial-bug: #1348818

Note: There are several other unrelated unit tests that also break with a
randomized PYTHONHASHSEED, but they are not addressed here. They will be
addressed in separate patches.

Change-Id: Ibe2f4d929b8b42c8c909c2306d2554faf7109b49
neutron/tests/unit/agent/linux/test_ovs_lib.py