]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove env from rootwrap filter
authorDirk Mueller <dirk@dmllr.de>
Thu, 16 Jan 2014 21:59:41 +0000 (22:59 +0100)
committerDirk Mueller <dirk@dmllr.de>
Fri, 17 Jan 2014 16:50:50 +0000 (17:50 +0100)
commit9c1ad54e7815d50d9561d88337724ad2042c92a2
treed614eb41934ac38fc795d87ddc7e537fe18b7fbb
parent5be4620ae5bb50c8436de0e11269c85a095ed40b
Remove env from rootwrap filter

Allowing 'env' as a CommandFilter is similar to
allowing '/bin/bash', which makes all of rootwrap pointless.
Use EnvFilter instead. Change corresponding commands
that use env for setting C locale and adjust rootwrap
filters accordingly.

Several commands that output information that is
parsed as input by cinder change their behavior
based on the environment locale, which is depending
on local system settings. The code is however only
able to parse in C locale, so enforce that one.

Closes-Bug: #1269958

Change-Id: Ie1463e608c80204c7a8906efb95899a66aa733da
cinder/brick/local_dev/lvm.py
cinder/tests/brick/test_brick_lvm.py
etc/cinder/rootwrap.d/volume.filters