]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Refactoring cleanup for L3 agent callbacks
authorPaul Michali <pc@michali.net>
Wed, 1 Apr 2015 17:47:43 +0000 (13:47 -0400)
committerPaul Michali <pc@michali.net>
Fri, 3 Apr 2015 15:09:28 +0000 (11:09 -0400)
commit9bca9ca84b76cc5bba03e9c0ff42bceaf5d2b028
treeec09891e81ba77e36d48018ce8d940de35cbdb88
parent30c2e203d9cba559d7533ab5dbd5b45e5445e06d
Refactoring cleanup for L3 agent callbacks

This commit completes the refactoring of the L3 agent callback mechanism.
The goal here is to also use the neutron/callbacks/ mechanism for L3 agent
notifications, instead of have two mechanisms.

[1] modified the L3 agent to send notifiactions for router create, udpate,
and delete events, using the neutron/callbacks/ mechanism.

[2] modified VPN to use this new mechanism, instead of the L3EventObservers
mechanism. Note:

[3] modified FW repo to no longer depended on the L3EventObserver and
related objects (it doesn't currently use the event notifications).

This commit removes the notifications for the L3EventObservers mechanism,
removed the related modules and tests, and adds in tests to verify that the
new notifications are called for the different events.

Once [1] and [2] are upstreamed, this commit can proceed.

Refs:
[1] https://review.openstack.org/#/c/164466/
[2] https://review.openstack.org/#/c/165226/
[3] https://review.openstack.org/#/c/167275/

Change-Id: I7c4b4ea5f9fb19abb812665cdae5fb70c84fe3ec
Depends-On: If5040a827a6903cc7cb5e59cdb7fb95f61b13d47
Closes-Bug: #1433552
neutron/agent/l3/agent.py
neutron/agent/l3/event_observers.py [deleted file]
neutron/agent/metadata/driver.py
neutron/services/advanced_service.py [deleted file]
neutron/tests/functional/agent/test_l3_agent.py
neutron/tests/unit/agent/test_l3_event_observers.py [deleted file]
neutron/tests/unit/services/test_advanced_service.py [deleted file]