]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Fix race condition on processing DVR floating IPs
authorrajeev <rajeev.grover@hp.com>
Mon, 13 Oct 2014 20:25:36 +0000 (16:25 -0400)
committerrajeev <rajeev.grover@hp.com>
Mon, 20 Oct 2014 23:06:45 +0000 (19:06 -0400)
commit9902400039018d77aa3034147cfb24ca4b2353f6
tree3a3fc2abf8385b212326fb0a678ec37a96307571
parent5ba1dae2d1f7cf902b28c35299aae97c8c76164c
Fix race condition on processing DVR floating IPs

Fip namespace and agent gateway port can be shared by multiple dvr routers.
This change uses a set as the control variable for these shared resources
and ensures that Test and Set operation on the control variable are
performed atomically so that race conditions do not occur among
multiple threads processing floating IPs.
Limitation: The scope of this change is limited to addressing the race
condition described in the bug report. It may not address other issues
such as pre-existing issue with handling of DVR floatingips on agent
restart.

closes-bug: #1381238

Change-Id: I6dc2b7bad6e8ddbaa86c1f7a1e2028aeacc3afef
neutron/agent/l3_agent.py
neutron/tests/unit/test_l3_agent.py