]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Logging not using oslo.i18n guidelines (zonemgr)
authorSean McGinnis <sean_mcginnis@dell.com>
Tue, 5 May 2015 20:57:30 +0000 (15:57 -0500)
committerSean McGinnis <sean_mcginnis@dell.com>
Wed, 6 May 2015 13:11:46 +0000 (08:11 -0500)
commit98dbadc20af6d07c9ab80795c22a913a990ee063
treec8249e8604bfe8d30e8bc361d33487b767c5a58f
parent9d1650d5fd175c0d538bf3effe75addfa01d2b33
Logging not using oslo.i18n guidelines (zonemgr)

Multi-patch set for easier chunks. This one addresses
the zonemanager cinder directory.

There have been quite a few instances found where the
i18n guidelines are not being followed. I believe this
has helped lead to some of the confusion around how to
correctly do this. Other developers see this code and
assume it is an example of the correct usage.

This patch attempts to clean up most of those violations
in the existing codebase to hopefully help avoid some of
that confusion in reviews.

Some issues address:
* Correct log translation markers for different log levels
* Passing format values as arguments to call, not preformatting
* Not forcing translation via six.text_type and others

Guidelines can be found here:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html

Hacking checks will not be able to identify all violations of
the guidelines, but it could be useful for catching obvious
one such as LOG.info("No markers!").

Change-Id: I992234cdbe3ac8c59d4c6a6c5362b009162ba38a
Partial-bug: 1433216
cinder/hacking/checks.py
cinder/zonemanager/drivers/brocade/brcd_fabric_opts.py
cinder/zonemanager/drivers/brocade/brcd_fc_san_lookup_service.py
cinder/zonemanager/drivers/brocade/brcd_fc_zone_client_cli.py
cinder/zonemanager/drivers/brocade/brcd_fc_zone_driver.py
cinder/zonemanager/drivers/cisco/cisco_fc_san_lookup_service.py
cinder/zonemanager/drivers/cisco/cisco_fc_zone_client_cli.py
cinder/zonemanager/drivers/cisco/cisco_fc_zone_driver.py
cinder/zonemanager/fc_san_lookup_service.py
cinder/zonemanager/fc_zone_manager.py
cinder/zonemanager/utils.py